dotnet / llilc

This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.
MIT License
1.52k stars 153 forks source link

Extend SwitchSection API #1070

Closed nattress closed 7 years ago

nattress commented 7 years ago

Provide more precise control over custom sections. Previously we would create a custom section for Comdat data and refer to it by name when switching to it. However we really want custom sections with the same name as existing sections, differing only on attributes or comdat name. To accomplish this, remove the name -> MCSection mapping and provide an extended API for switching sections that allows Comdat / attributes to be specified.

nattress commented 7 years ago

@sandreenko PTAL. This is the objectwriter piece of a related commit in CoreRT. See https://github.com/nattress/corert/commit/8590ef5f9bbea9b57a48f5e031c960e10a15477e.

nattress commented 7 years ago

@sandreenko Updated. Please merge if this looks good. I will refresh the nuget packages as of these commits.