dotnet / machinelearning-modelbuilder

Simple UI tool to build custom machine learning models.
Creative Commons Attribution 4.0 International
263 stars 56 forks source link

Change DLL Names and Namespaces #186

Closed JakeRadMSFT closed 4 years ago

JakeRadMSFT commented 5 years ago

Bug description We need to update our assemblies to have better names. Kathleen Dollard has sent out mail requiring all assemblies and tools to have Microsoft Prefix.

My Suggestion:

CLI: Microsoft.MachineLearning.Net.CLI Model Builder: Microsoft.MachineLearning.Net.ModelBuilder Code Gen: Microsoft.MachineLearning.Net.CodeGen

JakeRadMSFT commented 5 years ago

Goal is to increase confidence that something is coming from Microsoft (in addition to it being signed).

justinormont commented 5 years ago

I would sync w/ ML.NET folks on the topic of namespaces. I generally think these should be under Microsoft.ML.* namespace.

The mlnet NuGet was named to be able to have a short dotnet tool install -g mlnet.

/cc @eerhardt

eerhardt commented 5 years ago

The mlnet NuGet was named to be able to have a short dotnet tool install -g mlnet.

Agreed. We should keep the CLI tool named mlnet. /cc @CESARDELATORRE @rustd

Microsoft.MachineLearning.Net.CLI

I generally think these should be under Microsoft.ML.* namespace.

I think we should keep Microsoft.ML instead of spelling out MachineLearning to match the runtime. Also .Net. in a .NET namespace or assembly name is redundant.

Maybe we could have all the tooling under Microsoft.ML.Design.*, or Microsoft.ML.Tools.*. Or possibly:

CLI: Microsoft.ML.CLI Model Builder: Microsoft.ML.ModelBuilder Code Gen: Microsoft.ML.CodeGen

JakeRadMSFT commented 5 years ago

I'm sold on the proposal from @eerhardt & @justinormont :)

JakeRadMSFT commented 5 years ago

@LittleLittleCloud lets update the names before adding the internals visible to :)

LittleLittleCloud commented 5 years ago

namespace for Code Gen will be: Microsft.ML.CodeGen

JakeRadMSFT commented 5 years ago

Please update to Microsft.ML.CodeGeneration

LittleLittleCloud commented 5 years ago

Please update to Microsft.ML.CodeGeneration

Just the NameSpace? or also include the DLL

JakeRadMSFT commented 5 years ago

Please update to Microsft.ML.CodeGeneration

Just the NameSpace? or also include the DLL

Both