search

dotnet / machinelearning-modelbuilder

Simple UI tool to build custom machine learning models.
Creative Commons Attribution 4.0 International
264 stars 56 forks source link

All Scenarios: The "Save" button should be disabled on the "Advanced training options" dialog. #2691

Open v-Hailishi opened 1 year ago

v-Hailishi commented 1 year ago

System Information (please complete the following information): Windows OS: Windows-11-Enterprise-22H2 ML.Net Model Builder 2022: 17.16.0.2330501 (Main Build) Microsoft Visual Studio Enterprise: 2022(17.5.5) .Net: 6.0, 7.0

Describe the bug

TestMatrix https://testpass.blob.core.windows.net/test-pass-data/wikipedia-detox-250-line-data.tsv

To Reproduce Steps to reproduce the behavior:

  1. Select Create a new project from the Visual Studio start window.
  2. Choose the C# Console App (.NET Core) project template.
  3. Add model builder by right click on the project.
  4. Select any scenario.
  5. On Data page, choose the data source.
  6. On the Train page, click the "Advanced training options..." link.

Expected behavior The "Save" button should be disabled on the "Advanced training options" dialog.

Screenshot image

Additional context

luisquintanilla commented 1 year ago

From a code perspective this is expected because choosing "Advanced training options" modifies the MBConfig. However, from a UI / user perspective, since nothing has changed it should be disabled.