search

dotnet / machinelearning-modelbuilder

Simple UI tool to build custom machine learning models.
Creative Commons Attribution 4.0 International
263 stars 56 forks source link

AutoML CLI ignores the normalized column name #427

Closed justinormont closed 4 years ago

justinormont commented 5 years ago

In the normalization function for column names, we call the Sanitize() function, then ignore its result (besides the 1st letter).

This line: https://github.com/dotnet/machinelearning/blob/a15aaa73ffa3798d4ab6c79672a7d3859d36030b/src/mlnet/Utilities/Utils.cs#L81

Should be:

return sanitizedInput.First().ToString().ToUpper() + sanitizedInput.Substring(1);

Noted as something to fix after https://github.com/dotnet/machinelearning/pull/3882 is merged into master.

LittleLittleCloud commented 4 years ago

Thanks, @justinormont ,

@JakeRadMSFT going to move this one to validate panel since it's already been fixed