Change from error to warning dialog

dotnet / machinelearning-modelbuilder

Simple UI tool to build custom machine learning models.

Creative Commons Attribution 4.0 International

263 stars 56 forks source link

Change from error to warning dialog #53

Closed luisquintanilla closed 4 years ago

luisquintanilla commented 5 years ago

System Information (please complete the following information):

Model Builder Version: 16.0.1905.641
Visual Studio Version: 2017, 2019

Describe the bug After training is successful, and the generated projects have been added to the current solution, when trying to close the ML.NET Model Builder screen, an error prompt asks whether the user wants to cancel training.

Expected behavior

If training is successful and projects have been added to current solution, no error prompt should appear when closing ML.NET Model Builder screen.

Screenshots

tbombach commented 5 years ago

Thanks for filing this @luisquintanilla! Definitely a bug and something we want to fix. Thank you!

rustd commented 5 years ago

Change dialog from "Error - Warning". Update error message - "Model Builder"

tbombach commented 5 years ago

Engineering work:

We currently have code that determines if the window should close (https://github.com/dotnet/machinelearning-tools/blob/master/MLNET%20Model%20Builder/ToolWindows/TrainModelToolWindowControl.xaml.cs#L64). It currently checks if the user has made changes and prompt if the user has. We should skip prompting if the user has completed the "Code" tab.

rustd commented 5 years ago

Change the title of dialog box to say Warning. That is the only change required.