search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

ML.Ensemble assembly is not part of any NuGet #1078

Closed ganik closed 5 years ago

ganik commented 6 years ago

ML.NET 0.6

ML.Ensemble is not put into any of ML.NET NuGets

eerhardt commented 6 years ago

@shauheen - this should be a pretty easy fix. I assume we want this in the Microsoft.ML nuget package.

suhailsinghbains commented 6 years ago

Hi, I am new to this and sending a PR right away. Thanks

suhailsinghbains commented 6 years ago

Should I remove every instance of ML.Ensemble from the whole project(s) or just the ML.Core? that would be very helpful. Thanks

eerhardt commented 6 years ago

The fix here is to add ML.Ensemble to the Microsoft.ML nuget package. To do this,

https://github.com/dotnet/machinelearning/blob/53cdb20358e7ae98cdaf6de198e35f48fbdac269/src/Microsoft.ML.Ensemble/Microsoft.ML.Ensemble.csproj#L5

Needs to change to Microsoft.ML.

The alternative is to actually create a Microsoft.ML.Ensemble project under https://github.com/dotnet/machinelearning/tree/master/pkg.

@TomFinley @Zruty0 - any opinion on which way to go here? Is the stuff in ML.Ensemble considered "core" and should be put into the Microsoft.ML package? Or should it go in its own separate package?

Since we haven't had a customer complain that we aren't shipping this, it doesn't feel like it is a "core" scenario, so having a separate package seems justified to me.

suhailsinghbains commented 6 years ago

Ohh thanks for giving me an insight, very interesting. I'll wait for the tagged people to reply and start with the bug right away :)

suhailsinghbains commented 5 years ago

I'll send a PR for the 1st solution given soon, as I really want to solve the bug :)