Please add support for Visual Basic.Net

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.

https://dot.net/ml

MIT License

9.04k stars 1.89k forks source link

Please add support for Visual Basic.Net #3679

Open popasUC opened 5 years ago

popasUC commented 5 years ago

System information

OS version/distro:
.NET Version (eg., dotnet --info):

Issue

It looks like this Visual Studio extension does not currently work in Visual Basic .Net projects.

What did you do? Installed the ML.Net Model Builder extension in Visual Studio 2019. Created a new VB.Net project and a new C# project.
What happened? The ML.Net Model Builder extension worked in the C# project (Add - Machine Learning opened the ML.Net Model Builder tab). Pass for C#.

The ML.Net Model Builder extension did not work in the VB.Net project (Add - Machine Learning was not even available). FAIL for VB.Net.

What did you expect? It would be nice for this extension to work in VB.Net projects as well. You would more than double your audience!

Source code / logs

Please paste or attach the code or logs or traces that would be helpful to diagnose the issue you are reporting.

danucalovj commented 5 years ago

+1 on this request.

I've been refactoring the C# code and samples to VB.Net all along. Not sure how the AutoML builder will handle generating code for VB.Net since the Tuples class needs to be imported in VB for generating predictions, unlike C# where it seems to be built-in, but definitely would be nice!

danucalovj commented 5 years ago

@popasUC here is what I was referring to regarding the manual conversion process if it helps... Posted this question on SO and after further investigation found the answer myself. Just note that this code was built with a preview version of ML.Net, not the release version so not sure what changes:

https://stackoverflow.com/questions/55658655/c-sharp-to-vb-conversion-for-ienumerable-with-tuples

popasUC commented 5 years ago

Nice work @danucalovj !

I thought Tuples are fully supported in VB.Net (at parity with C#), at least in recent versions: https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/language-features/data-types/tuples https://www.infoq.com/news/2017/04/VB-15

Am I missing anything?

justinormont commented 5 years ago

Does the C# project compile compile correctly in your solution and is it callable as a library from the VB.NET code?

@rustd: Do you know we expose Model Builder from a VB project?

rustd commented 5 years ago

Model Builder is only support for C# projects for now.

popasUC commented 5 years ago

Does the C# project compile compile correctly in your solution and is it callable as a library from the VB.NET code?

I expect it to work and that's my backup for the time-being.

@rustd: Do you know we expose Model Builder from a VB project?

This would be preferable in the long run. Despite what some oblivious people think, the community of VB.Net users and supporters is like a very large iceberg - with a huge potential market, especially for Data Science related applications. According to some popularity indexes, VB.Net surpasses C# by a good margin. Why miss about half of the market?