search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

DetectEntireAnomalyBySrCnn - No anomalies detected as of version 1.5.4 or greater #5891

Open luisquintanilla opened 3 years ago

luisquintanilla commented 3 years ago

System Information (please complete the following information):

Describe the bug

When using DetectEntireAnomalyBySrCnn with versions 1.5.4 or greater, no anomalies are detected when running the DetectAnomaly method from the phone call tutorial.

Changing options does nothing. Has anything changed with this algorithm that would suddenly make it stop working after 1.5.4?

If you run the sample using version 1.5.2 with the same data and options it works.

Related docs issue dotnet/docs#23888

To Reproduce

Follow the steps in the phone call tutorial. For reference, here's a completed code sample

Expected behavior

Anomalies are detected.

michaelgsharp commented 3 years ago

@luisquintanilla since this is a regression I would say its probably a higher priority. @briacht thoughts?

briacht commented 3 years ago

Yeah if the algorithm isn't working anymore we should definitely try and fix that

michaelgsharp commented 3 years ago

This is the PR that caused this bug https://github.com/dotnet/machinelearning/pull/5202.