search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.94k stars 1.86k forks source link

File-scoped namespaces in files under `ComponentModel` (`Microsoft.ML.Core`) #6788

Closed Lehonti closed 10 months ago

michaelgsharp commented 10 months ago

/azp run

azure-pipelines[bot] commented 10 months ago
Azure Pipelines successfully started running 2 pipeline(s).
codecov[bot] commented 10 months ago

Codecov Report

Merging #6788 (b83b18b) into main (39235a7) will increase coverage by 0.01%. The diff coverage is 71.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6788 +/- ## ========================================== + Coverage 69.03% 69.04% +0.01% ========================================== Files 1237 1237 Lines 252700 252700 Branches 26446 26446 ========================================== + Hits 174449 174478 +29 + Misses 71308 71283 -25 + Partials 6943 6939 -4 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `69.04% <71.32%> (+0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.62% <71.32%> (+0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...oft.ML.Core/ComponentModel/AssemblyLoadingUtils.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Db3JlL0NvbXBvbmVudE1vZGVsL0Fzc2VtYmx5TG9hZGluZ1V0aWxzLmNz) | `68.67% <68.96%> (ø)` | | | [...crosoft.ML.Core/ComponentModel/ComponentFactory.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Db3JlL0NvbXBvbmVudE1vZGVsL0NvbXBvbmVudEZhY3RvcnkuY3M=) | `75.00% <70.00%> (ø)` | | | [...crosoft.ML.Core/ComponentModel/ComponentCatalog.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Db3JlL0NvbXBvbmVudE1vZGVsL0NvbXBvbmVudENhdGFsb2cuY3M=) | `70.24% <70.14%> (ø)` | | | [...t.ML.Core/ComponentModel/LoadableClassAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Db3JlL0NvbXBvbmVudE1vZGVsL0xvYWRhYmxlQ2xhc3NBdHRyaWJ1dGUuY3M=) | `80.64% <83.11%> (ø)` | | | [...t.ML.Core/ComponentModel/ExtensionBaseAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Db3JlL0NvbXBvbmVudE1vZGVsL0V4dGVuc2lvbkJhc2VBdHRyaWJ1dGUuY3M=) | `100.00% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6788/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)