search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

File-scoped namespaces in files directly under `Microsoft.ML.Core` #6794

Closed Lehonti closed 6 months ago

michaelgsharp commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
michaelgsharp commented 1 year ago

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

Lehonti commented 1 year ago

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

Yes, I think it's probably an incorrect test. I don't know enough about the project so I refrained from modifying anything that could possibly alter the behavior of the code, and stuck to what I'm describing in the pull request (namely file-scoped namespaces). I usually do small changes like these when I'm just getting acquainted with a project.

michaelgsharp commented 10 months ago

/azp run

azure-pipelines[bot] commented 10 months ago
Azure Pipelines successfully started running 2 pipeline(s).