dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

Add performance benchmarks for dataframe arithmetic operations #6827

Closed asmirnov82 closed 1 year ago

asmirnov82 commented 1 year ago

fixes #6826

codecov[bot] commented 1 year ago

Codecov Report

Merging #6827 (bf8a372) into main (d692751) will increase coverage by 0.01%. Report is 2 commits behind head on main. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #6827      +/-   ##
==========================================
+ Coverage   68.99%   69.01%   +0.01%     
==========================================
  Files        1237     1237              
  Lines      253558   253564       +6     
  Branches    26542    26542              
==========================================
+ Hits       174944   174990      +46     
+ Misses      71663    71616      -47     
- Partials     6951     6958       +7     
Flag Coverage Δ
Debug 69.01% <66.66%> (+0.01%) :arrow_up:
production 63.58% <100.00%> (+0.02%) :arrow_up:
test 88.86% <60.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 42.50% <100.00%> (+0.50%) :arrow_up:
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.31% <100.00%> (+<0.01%) :arrow_up:
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs 0.00% <0.00%> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

asmirnov82 commented 1 year ago

@JakeRadMSFT could you please take a look?

JakeRadMSFT commented 1 year ago

On the surface these look fine to me - I'm not sure how we should integrate into our builds though. It would be great to have reports show up in PRs or somewhere ... so we can track how changes are impacting perf.