dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

Implement vectorized binary arithmetic operations #6854

Closed asmirnov82 closed 11 months ago

asmirnov82 commented 12 months ago

Part of #5695

Implement vectorized binary arithmetic operations, align internal Arithmetic API with the latest Tensor.Numeric API

asmirnov82 commented 12 months ago

@JakeRadMSFT could you please take a look?

codecov[bot] commented 11 months ago

Codecov Report

Merging #6854 (5cf12a0) into main (64d7ebd) will decrease coverage by 0.25%. The diff coverage is 73.17%.

@@            Coverage Diff             @@
##             main    #6854      +/-   ##
==========================================
- Coverage   69.63%   69.39%   -0.25%     
==========================================
  Files        1237     1238       +1     
  Lines      247617   249429    +1812     
  Branches    25436    25528      +92     
==========================================
+ Hits       172429   173090     +661     
- Misses      68577    69715    +1138     
- Partials     6611     6624      +13     
Flag Coverage Δ
Debug 69.39% <73.17%> (-0.25%) :arrow_down:
production 63.92% <70.96%> (-0.27%) :arrow_down:
test 88.89% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Microsoft.Data.Analysis/BitUtility.cs 84.78% <100.00%> (-0.64%) :arrow_down:
...icrosoft.Data.Analysis/Computations/Arithmetics.cs 44.84% <ø> (ø)
...lysis/PrimitiveColumnContainer.BinaryOperations.cs 100.00% <100.00%> (ø)
...FrameColumn.BinaryOperationAPIs.ExplodedColumns.cs 7.69% <ø> (ø)
...eColumn.BinaryOperationImplementations.Exploded.cs 76.47% <ø> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 73.07% <ø> (-0.37%) :arrow_down:
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.32% <100.00%> (+<0.01%) :arrow_up:
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 57.06% <76.19%> (ø)
...Microsoft.Data.Analysis/Computations/Arithmetic.cs 62.06% <62.06%> (ø)

... and 11 files with indirect coverage changes