search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

Updates LightGBM from 2.X.X to 3.X.X #6880

Closed michaelgsharp closed 10 months ago

michaelgsharp commented 10 months ago

Updates LightGBM from 2.X.X to 3.X.X and all the associated baseline test files.

Also updates the SQL nuget package for its security update.

michaelgsharp commented 10 months ago

No concern on the output changes. Besides the fact that the training size is so small that anything (sneezes included) can change the output, these results are 100% done by the third party library, so we are ok with all changes that come from their changes.

codecov[bot] commented 10 months ago

Codecov Report

Merging #6880 (6804745) into main (d2cf997) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6880 +/- ## ========================================== - Coverage 68.81% 68.80% -0.01% ========================================== Files 1240 1240 Lines 249392 249392 Branches 25493 25493 ========================================== - Hits 171607 171600 -7 - Misses 71191 71196 +5 - Partials 6594 6596 +2 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.80% <100.00%> (-0.01%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.26% <100.00%> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.49% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...rc/Microsoft.ML.LightGbm/WrappedLightGbmBooster.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5MaWdodEdibS9XcmFwcGVkTGlnaHRHYm1Cb29zdGVyLmNz) | `90.47% <100.00%> (ø)` | | | [.../Microsoft.ML.LightGbm/WrappedLightGbmInterface.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5MaWdodEdibS9XcmFwcGVkTGlnaHRHYm1JbnRlcmZhY2UuY3M=) | `87.71% <ø> (ø)` | | | [...cenariosWithDirectInstantiation/TensorflowTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdHMvU2NlbmFyaW9zV2l0aERpcmVjdEluc3RhbnRpYXRpb24vVGVuc29yZmxvd1Rlc3RzLmNz) | `91.71% <100.00%> (ø)` | | | [...osoft.ML.Tests/TrainerEstimators/TreeEstimators.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdHMvVHJhaW5lckVzdGltYXRvcnMvVHJlZUVzdGltYXRvcnMuY3M=) | `97.84% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6880/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)