search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.02k stars 1.88k forks source link

Rename NameEntity to NamedEntity #6917

Closed ericstj closed 9 months ago

ericstj commented 9 months ago

Renaming while obsoleting the public API. We'll backport this to 3.0, then we'll remove the obsolete members from 4.0.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (efab011) 68.79% compared to head (24053b3) 68.80%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6917 +/- ## ======================================= Coverage 68.79% 68.80% ======================================= Files 1249 1249 Lines 249431 249433 +2 Branches 25510 25510 ======================================= + Hits 171604 171613 +9 + Misses 71214 71211 -3 + Partials 6613 6609 -4 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.80% <81.81%> (+<0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.26% <80.00%> (+<0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.49% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [.../Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL05hc0JlcnQvTmFzQmVydFRyYWluZXIuY3M=) | `80.12% <100.00%> (ø)` | | | [src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL05hc0JlcnQvTmVyVHJhaW5lci5jcw==) | `88.23% <100.00%> (ø)` | | | [test/Microsoft.ML.Tests/NerTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdHMvTmVyVGVzdHMuY3M=) | `100.00% <100.00%> (ø)` | | | [src/Microsoft.ML.TorchSharp/TorchSharpCatalog.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL1RvcmNoU2hhcnBDYXRhbG9nLmNz) | `60.00% <0.00%> (-9.24%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6917/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
ericstj commented 9 months ago

Only failure here is #6921

ericstj commented 8 months ago

/backport to release/3.0

github-actions[bot] commented 8 months ago

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7453292024