Only use semi-colons for NoWarn - fixes build break

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.

https://dot.net/ml

MIT License

8.92k stars 1.86k forks source link

Only use semi-colons for NoWarn - fixes build break #6935

Closed ericstj closed 6 months ago

ericstj commented 6 months ago

Turns out that using a mix of semi-colons and commas doesn't work correctly. The NoWarn value I added for NETSDK1206 was being ignored due to the way this property was split.

Fix this by standardizing on ;

ericstj commented 6 months ago

So the bug here is that MSBuild only permits ;, whereas the compiler permits both , and ;. https://github.com/dotnet/msbuild/issues/7094 tracks fixing this.

ericstj commented 6 months ago

Merging without review to unblock the rolling build