search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.92k stars 1.86k forks source link

Split out non concurrent test collections. #6937

Closed michaelgsharp closed 5 months ago

michaelgsharp commented 6 months ago

Split out non-concurrent test collections to improve performance.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (373a864) 68.80% compared to head (a8dfb40) 68.81%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6937 +/- ## ======================================== Coverage 68.80% 68.81% ======================================== Files 1249 1249 Lines 249436 249644 +208 Branches 25468 25481 +13 ======================================== + Hits 171635 171783 +148 - Misses 71211 71271 +60 Partials 6590 6590 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.81% <75.00%> (+<0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.28% <95.45%> (+0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.41% <68.04%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [.../Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL05hc0JlcnQvTmFzQmVydFRyYWluZXIuY3M=) | `80.36% <100.00%> (+0.24%)` | :arrow_up: | | [...c/Microsoft.ML.TorchSharp/TorchSharpBaseTrainer.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL1RvcmNoU2hhcnBCYXNlVHJhaW5lci5jcw==) | `84.98% <100.00%> (ø)` | | | [...ft.ML.Core.Tests/UnitTests/TestResourceDownload.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuQ29yZS5UZXN0cy9Vbml0VGVzdHMvVGVzdFJlc291cmNlRG93bmxvYWQuY3M=) | `0.00% <ø> (ø)` | | | [...ft.ML.TensorFlow.Tests/TensorFlowEstimatorTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVuc29yRmxvdy5UZXN0cy9UZW5zb3JGbG93RXN0aW1hdG9yVGVzdHMuY3M=) | `98.50% <ø> (ø)` | | | [...t/Microsoft.ML.TensorFlow.Tests/TensorflowTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVuc29yRmxvdy5UZXN0cy9UZW5zb3JmbG93VGVzdHMuY3M=) | `91.71% <ø> (ø)` | | | [test/Microsoft.ML.Tests/DatabaseLoaderTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdHMvRGF0YWJhc2VMb2FkZXJUZXN0cy5jcw==) | `94.41% <100.00%> (+0.17%)` | :arrow_up: | | [...rosoft.ML.TorchSharp.Tests/ObjectDetectionTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVG9yY2hTaGFycC5UZXN0cy9PYmplY3REZXRlY3Rpb25UZXN0cy5jcw==) | `100.00% <ø> (ø)` | | | [test/Microsoft.ML.TorchSharp.Tests/QATests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVG9yY2hTaGFycC5UZXN0cy9RQVRlc3RzLmNz) | `40.50% <ø> (ø)` | | | [...oft.ML.TorchSharp.Tests/TextClassificationTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVG9yY2hTaGFycC5UZXN0cy9UZXh0Q2xhc3NpZmljYXRpb25UZXN0cy5jcw==) | `85.17% <ø> (ø)` | | | [src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Ub3JjaFNoYXJwL05hc0JlcnQvTmVyVHJhaW5lci5jcw==) | `91.10% <94.73%> (+2.86%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6937/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
michaelgsharp commented 5 months ago

@tarekgh could you take a quick look at this when you have a minute? It just splits out some test assemblies so we can run more in parallel.

michaelgsharp commented 5 months ago

/backport to release/3.0

github-actions[bot] commented 5 months ago

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7455070236

michaelgsharp commented 5 months ago

/backport to release/3.0

github-actions[bot] commented 5 months ago

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7464450572