Closed dotnet-maestro[bot] closed 5 months ago
We need to port changes from https://github.com/dotnet/machinelearning/pull/6703 and https://github.com/dotnet/machinelearning/pull/6935 here.
Attention: 44 lines
in your changes are missing coverage. Please review.
Comparison is base (
d96d7b7
) 68.81% compared to head (df6f817
) 68.80%.
We may want to "merge" commit on this one to preserve distinct history. I can rebase to combine all the small changes from the previous arcade PR to clean things up. Will do that after I see the build passing for auditing purposes (making sure I got every relevant commit).
Hmm, a couple unique failures here. On Ubuntu:
Finished test: Microsoft.ML.Scenarios.TensorFlowScenariosTests.TensorFlowTransformInputOutputTypesTest with memory usage 2,374,266,880.00
Starting test: Microsoft.ML.Tests.NerTests.TestSimpleNer
Finished test: Microsoft.ML.Tests.NerTests.TestSimpleNer with memory usage 1,505,148,928.00
Starting test: Microsoft.ML.Tests.ObjectDetectionTests.SimpleObjDetectionTest
total : 171, filtered: 0, filter ratio: 0.000%
Finished test: Microsoft.ML.Tests.ObjectDetectionTests.SimpleObjDetectionTest with memory usage 1,648,238,592.00
Starting test: Microsoft.ML.Tests.QATests.TestSimpleQA
Killed
+ export _commandExitCode=137
Maybe OOM killer? Though memory went down from previous tests, not sure how much is needed for QA.
Coverage build failed SdcaLogisticRegression
test with Assert.InRange() Failure: Value not in range\r\nRange: (0 - 0.5)\r\nActual: 0.51672692765628392
https://dev.azure.com/dnceng-public/public/_build/results?buildId=516419&view=ms.vss-test-web.build-test-results-tab&runId=12113782&resultId=101543
Both of these seem unrelated to this change, but curious for your thoughts @michaelgsharp
Seems like those were flaky. This is ready for review @michaelgsharp
@michaelgsharp this is still waiting on your review, please 🙏
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: 45c6fd49-3a4f-4675-f3da-08dc0c527e17
Build: 20231220.2
Date Produced: December 20, 2023 12:15:53 PM UTC
Commit: 84129325171e65373edef24019e1171feeb19cbc
Branch: refs/heads/release/8.0
Updates:
Updates to .NET SDKs: