search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.92k stars 1.86k forks source link

Packaging cleanup #6939

Closed ericstj closed 4 months ago

ericstj commented 6 months ago

Originally I was just trying to remove mentions of snupkg, but then things got a bit carried away. :)

This is trying to remove as much duplication and dead code related to packaging that I can.

I'll be validating these changes with diffs and refining a bit more but wanted to get this up and see if CI is happy.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.79%. Comparing base (0d2fd60) to head (59f414d). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6939 +/- ## ========================================== - Coverage 68.83% 68.79% -0.05% ========================================== Files 1258 1254 -4 Lines 250674 250204 -470 Branches 25615 25529 -86 ========================================== - Hits 172557 172128 -429 + Misses 71486 71466 -20 + Partials 6631 6610 -21 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.79% <ø> (-0.05%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.22% <ø> (-0.06%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.50% <ø> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 29 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
ericstj commented 5 months ago

Still something wonky happening with the build of the analyzer that I haven't quite determined. Looks to me like it's building concurrently in two separate processes.

Here's the nuspec diff of the current changes. https://github.com/ericstj/diffs/commit/ecf911b5ccd4ec488d08ba7a9f7d4a5c8f1cba4a

ericstj commented 5 months ago

/azp run MachineLearning-CI

azure-pipelines[bot] commented 5 months ago
Pull request contains merge conflicts.
ericstj commented 4 months ago

/azp run MachineLearning-CI

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ericstj commented 4 months ago

I'm going to rename the projects to CSProj and put everything in the sln to make this work better with fewer custom steps.

ericstj commented 4 months ago

@michaelgsharp/@viktorhofer can you take another look at this? I'm going to stop short of pipeline refactoring on this and do that in a separate PR.

ericstj commented 4 months ago

Here's an updated diff of NuSpecs, comparing the latest from main with the updates in this PR: https://github.com/ericstj/diffs/commit/26178c06087ac37c140a6bcac94ea6b3b1efb8ab