Closed LittleLittleCloud closed 5 months ago
Interesting, the addition of SearchSpace
sub-namespace now causes a type name resolution problem:
https://github.com/dotnet/machinelearning/blob/d0d8569220da60ff8acde3650393110c54dea8d0/src/Microsoft.ML.TorchSharp/NasBert/Models/NasBertEncoder.cs#L258-L264
Looks like those were meant to refer to this internal class: https://github.com/dotnet/machinelearning/blob/d0d8569220da60ff8acde3650393110c54dea8d0/src/Microsoft.ML.TorchSharp/NasBert/Modules/SearchSpace.cs#L13
Maybe we just rename that @michaelgsharp?
Attention: 33 lines
in your changes are missing coverage. Please review.
Comparison is base (
d0d8569
) 68.80% compared to head (64a8a73
) 68.80%.
@ericstj any classes directly involved in the TorchSharp model itself need to match names exactly with the name that was used to save the weights file. We could try and rename this file and see if things still load, but if its at all saved in the weights file its not a class that we can rename. I'll test that out and add a comment here about it.
/backport to release/3.0
Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7481061541
any classes directly involved in the TorchSharp model itself need to match names exactly with the name that was used to save the weights file.
How would we be persisting the name of this static class in our saved file? Still might be worth renaming since we try to avoid name collisions in our codebases.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.Fix #6949