search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.92k stars 1.86k forks source link

[release/3.0] fix #6949 #6953

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 5 months ago

Backport of #6951 to release/3.0

/cc @michaelgsharp @LittleLittleCloud

Customer Impact

There is no workaround an end user could do to avoid this issue if they do hit it.

Testing

This exposed a testing hole that we have. We are going to add in "package testing" in order to catch situations like this before they are released.

Risk

Mid level risk. We are adding a new public type that could potentially have collisions with user.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release/3.0@a5b5c7a). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/3.0 #6953 +/- ## ============================================== Coverage ? 68.80% ============================================== Files ? 1240 Lines ? 249652 Branches ? 25511 ============================================== Hits ? 171774 Misses ? 71277 Partials ? 6601 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6953/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.80% <0.00%> (?)` | | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.27% <0.00%> (?)` | | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.41% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.