dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.92k stars 1.86k forks source link

[release/3.0] Update dependencies from dotnet/arcade #6974

Closed dotnet-maestro[bot] closed 5 months ago

dotnet-maestro[bot] commented 5 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

carlossanlop commented 5 months ago

I have no permissions in this repo, I'm a mere peasant. @ericstj @michaelgsharp I triggered this arcade flow, it includes my fix that adds the net6.0 tfm to RemoteExecutor.

ericstj commented 5 months ago

@carlossanlop you should have permissions now. @michaelgsharp would have more context on what we'd need to pick up Arcade's RemoteExecutor - is it as simple as just deleting the fork and adding a package reference?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (74b8386) 68.80% compared to head (608ce86) 68.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/3.0 #6974 +/- ## =============================================== - Coverage 68.80% 68.80% -0.01% =============================================== Files 1240 1240 Lines 249652 249652 Branches 25511 25511 =============================================== - Hits 171777 171769 -8 - Misses 71274 71281 +7 - Partials 6601 6602 +1 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6974/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.80% <ø> (-0.01%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.27% <ø> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.41% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6974/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
michaelgsharp commented 5 months ago

Once we drop .net standard support I think thats all we will need to do.

ericstj commented 5 months ago

Once we drop .net standard support I think thats all we will need to do.

We don't test against netstandard2.0 - RemoteExecutor should be supporting the frameworks we test against.

ericstj commented 5 months ago

Looks like https://github.com/dotnet/machinelearning/issues/3164 exists to track adopting RemoteExecutor.