dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.92k stars 1.86k forks source link

Update OnnxRuntime to 1.16.3 #6975

Closed michaelgsharp closed 4 months ago

michaelgsharp commented 5 months ago

Updates OnnxRuntime to 1.16.3 and fixes the breaking change.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e28578) 68.80% compared to head (859c078) 68.83%. Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6975 +/- ## ========================================== + Coverage 68.80% 68.83% +0.02% ========================================== Files 1249 1258 +9 Lines 249686 250674 +988 Branches 25485 25615 +130 ========================================== + Hits 171806 172556 +750 - Misses 71286 71487 +201 - Partials 6594 6631 +37 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.83% <100.00%> (+0.02%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.27% <100.00%> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.56% <ø> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5Pbm54VHJhbnNmb3JtZXIvT25ueFV0aWxzLmNz) | `84.21% <100.00%> (+0.12%)` | :arrow_up: | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/6975/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
ericstj commented 4 months ago

/azp run MachineLearning-CI

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ericstj commented 4 months ago

Seems like the failure is OnnxRuntime related: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6975-merge-6fd5fb0c27da42dbaa/Microsoft.ML.AutoML.Tests/1/console.d0e26785.log?helixlogtype=result

    Microsoft.ML.AutoML.Test.AutoFitTests.AutoFitMultiClassification_Image_CV [FAIL]
      System.AggregateException : One or more errors occurred. (The type initializer for 'Microsoft.ML.OnnxRuntime.NativeMethods' threw an exception.)
      ---- System.TypeInitializationException : The type initializer for 'Microsoft.ML.OnnxRuntime.NativeMethods' threw an exception.
      -------- System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
           at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
           at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
           at System.Threading.Tasks.Task`1.get_Result()
        D:\a\_work\1\s\src\Microsoft.ML.AutoML\AutoMLExperiment\AutoMLExperiment.cs(204,0): at Microsoft.ML.AutoML.AutoMLExperiment.Run()