Closed michaelgsharp closed 3 months ago
Attention: Patch coverage is 89.08795%
with 67 lines
in your changes are missing coverage. Please review.
Project coverage is 69.03%. Comparing base (
902102e
) to head (8b6fa30
). Report is 22 commits behind head on main.
/azp run
/azp run
/azp run
Seems like CA2213
should have caught these, but it's disabled. It would be good to re-enable it and ensure it catches these problems and ensure we got them all. Separately we might need to have an audit of all of our ruleset (compare with runtime) to see if we have others disabled.
So I just tried to enable CA2213 and we have a LOT of issues with it in our repo. I think it would be better to have a separate PR that does just that by itself, as it seems like it will be a decent amount of changes.
/azp run
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.