search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.91k stars 1.86k forks source link

Remove SourceLink SDK references #7037

Closed ericstj closed 4 months ago

ericstj commented 4 months ago

@ViktorHofer let me know that we no longer need to have explicit SDK references to these source-link packages.

I'm removing them and also testing the behavior of build to ensure we still have source-link info in our binaries per https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink.

ViktorHofer commented 4 months ago

Please also remove the other hits, i.e. Tools.props: https://github.com/search?q=repo%3Adotnet%2Fmachinelearning%20sourcelink&type=code

ericstj commented 4 months ago

I found quite a few other dead dependencies here that I was able to clean up. I have also confirmed that the binaries / pdbs / packages still have source link info after this change.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.79%. Comparing base (f22b60a) to head (bbc8bd8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7037 +/- ## ======================================= Coverage 68.79% 68.79% ======================================= Files 1254 1254 Lines 250204 250204 Branches 25529 25529 ======================================= + Hits 172129 172134 +5 + Misses 71465 71460 -5 Partials 6610 6610 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7037/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.79% <ø> (+<0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.23% <ø> (+<0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7037/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)