search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.91k stars 1.86k forks source link

Update package versions in use by ML.NET tests #7055

Closed ericstj closed 3 months ago

ericstj commented 3 months ago

Will backport this to the 3.0 branch too.

This also updates Newtonsoft which is a product dependency - but only updates to the latest servicing release which we can do as a servicing release ourselves.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.82%. Comparing base (59973fc) to head (b3b2f24).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7055 +/- ## ========================================== - Coverage 68.82% 68.82% -0.01% ========================================== Files 1255 1255 Lines 250358 250358 Branches 25550 25550 ========================================== - Hits 172306 172300 -6 - Misses 71440 71444 +4 - Partials 6612 6614 +2 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7055/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7055/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.82% <ø> (-0.01%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7055/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.25% <ø> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7055/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.50% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 7 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7055/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
ericstj commented 3 months ago

Let's update Protobuf separately. That one doesn't have a CG warning and it's across minor versions: 3.19.6 -> 3.25.3.

ericstj commented 3 months ago

/backport to release/3.0

github-actions[bot] commented 3 months ago

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/8256116339