search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.91k stars 1.86k forks source link

Update VMs #7087

Closed richlander closed 3 months ago

richlander commented 3 months ago

We are deprecating Ubuntu.1804.Amd64.Open.

ericstj commented 3 months ago

@michaelgsharp was already doing this in https://github.com/dotnet/machinelearning/pull/7034. I think we require more changes than just retargeting because of differences in test output. I'll defer to @michaelgsharp's call though.

ericstj commented 3 months ago

I see, we were not changing the build machines in that other PR - only helix queues.

michaelgsharp commented 3 months ago

I think it should be just fine. There are some fixes I need to do to update the Windows queues, but this doesn't change those so that won't hit it. We also build our official bits for Linux on CentOS machines, so this shouldn't have any problems/issues in that area either.

richlander commented 3 months ago

I also filed this issue: https://github.com/dotnet/machinelearning/issues/7088

I commented on the other PR.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.47%. Comparing base (8b483f4) to head (efec8e6). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7087 +/- ## ========================================== - Coverage 68.82% 68.47% -0.35% ========================================== Files 1255 1262 +7 Lines 250358 254263 +3905 Branches 25550 26236 +686 ========================================== + Hits 172310 174113 +1803 - Misses 71438 73470 +2032 - Partials 6610 6680 +70 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7087/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.47% <ø> (-0.35%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `62.87% <ø> (-0.39%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.56% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 19 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7087/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
richlander commented 3 months ago

Looks like the issue is on the Windows leg so I'll let you folks look at that.

ericstj commented 3 months ago

BuildAnalysis linked the failure to https://github.com/dotnet/machinelearning/issues/7067 which is a known issue in auto-ml tests. Merging.