search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.91k stars 1.86k forks source link

Fix DataFrame NullCount property of StringDataFrameColumn #7090

Closed asmirnov82 closed 2 months ago

asmirnov82 commented 3 months ago

Fixes #7089

asmirnov82 commented 3 months ago

@JakeRadMSFT could you please take a look?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.49%. Comparing base (d6d78fd) to head (3efeac0). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7090 +/- ## ========================================== - Coverage 68.82% 68.49% -0.33% ========================================== Files 1255 1262 +7 Lines 250358 254305 +3947 Branches 25550 26243 +693 ========================================== + Hits 172300 174187 +1887 - Misses 71445 73428 +1983 - Partials 6613 6690 +77 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.49% <100.00%> (-0.33%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `62.89% <100.00%> (-0.36%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.56% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...Analysis/DataFrameColumns/StringDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvU3RyaW5nRGF0YUZyYW1lQ29sdW1uLmNz) | `71.60% <100.00%> (+0.17%)` | :arrow_up: | | [...ta.Analysis.Tests/PrimitiveDataFrameColumnTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuRGF0YS5BbmFseXNpcy5UZXN0cy9QcmltaXRpdmVEYXRhRnJhbWVDb2x1bW5UZXN0cy5jcw==) | `99.70% <100.00%> (+<0.01%)` | :arrow_up: | ... and [70 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7090/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)