search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.91k stars 1.86k forks source link

Don't trigger PR validation builds for docs only changes #7096

Closed ericstj closed 3 months ago

ericstj commented 3 months ago

This applies the same filters we use in runtime to avoid building the repo when only docs change.

I tried to do this previously but I missed that the filter only applied to the rolling build and not PR validation.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.49%. Comparing base (d507a1e) to head (07421b0). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7096 +/- ## ========================================== + Coverage 68.47% 68.49% +0.01% ========================================== Files 1262 1262 Lines 254263 254295 +32 Branches 26236 26242 +6 ========================================== + Hits 174107 174175 +68 + Misses 73472 73430 -42 - Partials 6684 6690 +6 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7096/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7096/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.49% <ø> (+0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7096/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `62.89% <ø> (+0.02%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7096/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.56% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 10 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7096/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
steveharter commented 3 months ago

LGTM - verified the added lines are the same as the other sections in the same files.