search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
8.9k stars 1.86k forks source link

Extend dataframe orderby method to allow define null values ordering #7116

Closed asmirnov82 closed 2 months ago

asmirnov82 commented 2 months ago

Duplicate of #7118

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 79.86577% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 68.45%. Comparing base (79b5475) to head (bfe8ee2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7116 +/- ## ========================================== - Coverage 68.46% 68.45% -0.01% ========================================== Files 1263 1263 Lines 254956 254978 +22 Branches 26352 26357 +5 ========================================== - Hits 174552 174551 -1 - Misses 73698 73714 +16 - Partials 6706 6713 +7 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.45% <79.86%> (-0.01%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `62.84% <76.19%> (-0.02%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.58% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [src/Microsoft.Data.Analysis/DataFrame.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrame.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZS5jcw==) | `85.27% <100.00%> (-0.15%)` | :arrow_down: | | [src/Microsoft.Data.Analysis/DataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbi5jcw==) | `65.67% <100.00%> (+2.83%)` | :arrow_up: | | [...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FPrimitiveDataFrameColumn.Sort.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL1ByaW1pdGl2ZURhdGFGcmFtZUNvbHVtbi5Tb3J0LmNz) | `87.80% <100.00%> (+0.46%)` | :arrow_up: | | [...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=test%2FMicrosoft.Data.Analysis.Tests%2FDataFrameTests.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuRGF0YS5BbmFseXNpcy5UZXN0cy9EYXRhRnJhbWVUZXN0cy5jcw==) | `99.90% <100.00%> (+<0.01%)` | :arrow_up: | | [...Analysis/DataFrameColumns/StringDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FStringDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvU3RyaW5nRGF0YUZyYW1lQ29sdW1uLmNz) | `69.62% <84.84%> (-1.99%)` | :arrow_down: | | [...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FVBufferDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvVkJ1ZmZlckRhdGFGcmFtZUNvbHVtbi5jcw==) | `44.44% <57.14%> (-1.34%)` | :arrow_down: | | [...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FArrowStringDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvQXJyb3dTdHJpbmdEYXRhRnJhbWVDb2x1bW4uY3M=) | `63.17% <65.38%> (-0.38%)` | :arrow_down: | | [...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FPrimitiveDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL1ByaW1pdGl2ZURhdGFGcmFtZUNvbHVtbi5jcw==) | `71.83% <58.33%> (-0.70%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7116/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)