search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Update libmf submodule and reenable CodeQL on it #7159

Open ericstj opened 6 months ago

ericstj commented 6 months ago

Looks like we now have some warnings as errors on x86. That's noticing our intentional truncation - where before the truncation happened in the loop bounds as potentially infiinite loop. I'll need to make another change to libmf to fix this.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.65%. Comparing base (4d1a8c0) to head (6a03258). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7159 +/- ## ========================================== - Coverage 68.92% 68.65% -0.27% ========================================== Files 1396 1262 -134 Lines 266745 257767 -8978 Branches 27560 26660 -900 ========================================== - Hits 183849 176976 -6873 + Misses 75792 73978 -1814 + Partials 7104 6813 -291 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.65% <ø> (-0.27%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `62.93% <ø> (-0.59%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `88.85% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. [see 142 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)