dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Fixing native lookup #7282

Closed michaelgsharp closed 1 week ago

michaelgsharp commented 3 weeks ago

Fixes native lookup with adds a bunch more testing for M1 and normal mac as well.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (5b4981a) to head (96d6456). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs 0.00% 3 Missing and 1 partial :warning:
...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs 62.50% 1 Missing and 2 partials :warning:
...Common/Attributes/NativeDependencyFactAttribute.cs 0.00% 1 Missing and 1 partial :warning:
...mmon/Attributes/NativeDependencyTheoryAttribute.cs 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7282 +/- ## ========================================== - Coverage 68.87% 68.84% -0.04% ========================================== Files 1467 1473 +6 Lines 273954 274173 +219 Branches 28380 28424 +44 ========================================== + Hits 188693 188744 +51 - Misses 77952 78114 +162 - Partials 7309 7315 +6 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.84% <31.25%> (-0.04%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.29% <ø> (-0.05%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.16% <31.25%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...Common/Attributes/NativeDependencyFactAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FAttributes%2FNativeDependencyFactAttribute.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9BdHRyaWJ1dGVzL05hdGl2ZURlcGVuZGVuY3lGYWN0QXR0cmlidXRlLmNz) | `77.77% <0.00%> (-22.23%)` | :arrow_down: | | [...mmon/Attributes/NativeDependencyTheoryAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FAttributes%2FNativeDependencyTheoryAttribute.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9BdHRyaWJ1dGVzL05hdGl2ZURlcGVuZGVuY3lUaGVvcnlBdHRyaWJ1dGUuY3M=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: | | [...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FUtility%2FNativeLibrary.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9VdGlsaXR5L05hdGl2ZUxpYnJhcnkuY3M=) | `52.94% <62.50%> (+1.32%)` | :arrow_up: | | [...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FUtility%2FPathResolver.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9VdGlsaXR5L1BhdGhSZXNvbHZlci5jcw==) | `64.28% <0.00%> (-3.22%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7282/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
michaelgsharp commented 1 week ago

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

michaelgsharp commented 1 week ago

/backport to release/4.0

github-actions[bot] commented 1 week ago

Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/11787367067