dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Updated remote executor #7295

Closed michaelgsharp closed 1 week ago

michaelgsharp commented 1 week ago

Updates remote executor so that we can update the maintenance packages.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.87%. Comparing base (3659a48) to head (52abd6a). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7295 +/- ## ========================================== + Coverage 68.84% 68.87% +0.03% ========================================== Files 1471 1470 -1 Lines 274124 273991 -133 Branches 28411 28399 -12 ========================================== - Hits 188724 188721 -3 + Misses 78085 77956 -129 + Partials 7315 7314 -1 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.87% <100.00%> (+0.03%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.28% <ø> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.42% <100.00%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [test/Microsoft.ML.CpuMath.UnitTests/UnitTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295?src=pr&el=tree&filepath=test%2FMicrosoft.ML.CpuMath.UnitTests%2FUnitTests.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuQ3B1TWF0aC5Vbml0VGVzdHMvVW5pdFRlc3RzLmNz) | `95.70% <100.00%> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
ericstj commented 1 week ago

TorchSharp tests failing - most likely with OOM killer. https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-7295-merge-d2e8baee8ed043a68d/Microsoft.ML.TorchSharp.Tests/1/console.ce1a649e.log

Starting test: Microsoft.ML.TorchSharp.Tests.QATests.TestSimpleQA
Killed
+ export _commandExitCode=137

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-7295-merge-40b990e0aede49fb90/Microsoft.ML.TorchSharp.Tests/1/console.5d0e316a.log

Starting test: Microsoft.ML.TorchSharp.Tests.QATests.TestSimpleQA
/root/helix/work/correlation/scripts/414952a5ab8241c581e5bf6333bbe3ec/execute.sh: line 9:    19 Killed                  dotnet exec --roll-forward Major --runtimeconfig Microsoft.ML.TorchSharp.Tests.runtimeconfig.json --depsfile Microsoft.ML.TorchSharp.Tests.deps.json $HELIX_CORRELATION_PAYLOAD/xunit-runner/tools/netcoreapp2.0/xunit.console.dll Microsoft.ML.TorchSharp.Tests.dll -notrait Category=SkipInCI -xml testResults.xml
+ export _commandExitCode=137
+ _commandExitCode=137

Should be https://github.com/dotnet/machinelearning/issues/6978

michaelgsharp commented 1 week ago

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

michaelgsharp commented 1 week ago

/backport to release/4.0

github-actions[bot] commented 1 week ago

Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/11786408616