search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Backport GenAI #7298

Closed michaelgsharp closed 1 week ago

michaelgsharp commented 1 week ago

…270)

We are excited to review your PR.

So we can do the best job, please check:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 33.33333% with 152 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (2a879f6) to head (6ed398e). Report is 1 commits behind head on release/4.0.

Files with missing lines Patch % Lines
...rosoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs 0.00% 48 Missing :warning:
...osoft.ML.GenAI.Phi/Phi3/Phi3ChatTemplateBuilder.cs 43.83% 35 Missing and 6 partials :warning:
...crosoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs 0.00% 24 Missing :warning:
...rosoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs 0.00% 24 Missing :warning:
...soft.ML.GenAI.LLaMA/Llama3_1ChatTemplateBuilder.cs 69.23% 5 Missing and 3 partials :warning:
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs 60.00% 6 Missing :warning:
...enAI.Phi/Phi3/Phi3CausalLMChatCompletionService.cs 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/4.0 #7298 +/- ## =============================================== - Coverage 68.87% 68.84% -0.04% =============================================== Files 1469 1473 +4 Lines 273989 274159 +170 Branches 28389 28420 +31 =============================================== + Hits 188718 188746 +28 - Misses 77963 78095 +132 - Partials 7308 7318 +10 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.84% <33.33%> (-0.04%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.29% <30.27%> (-0.04%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.18% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...enAI.Phi/Phi3/Phi3CausalLMTextGenerationService.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Phi%2FPhi3%2FPhi3CausalLMTextGenerationService.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5QaGkvUGhpMy9QaGkzQ2F1c2FsTE1UZXh0R2VuZXJhdGlvblNlcnZpY2UuY3M=) | `35.71% <100.00%> (+1.56%)` | :arrow_up: | | [...st/Microsoft.ML.GenAI.LLaMA.Tests/LLaMA3\_1Tests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=test%2FMicrosoft.ML.GenAI.LLaMA.Tests%2FLLaMA3_1Tests.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuR2VuQUkuTExhTUEuVGVzdHMvTExhTUEzXzFUZXN0cy5jcw==) | `94.73% <100.00%> (+0.79%)` | :arrow_up: | | [...enAI.Phi/Phi3/Phi3CausalLMChatCompletionService.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Phi%2FPhi3%2FPhi3CausalLMChatCompletionService.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5QaGkvUGhpMy9QaGkzQ2F1c2FsTE1DaGF0Q29tcGxldGlvblNlcnZpY2UuY3M=) | `61.90% <83.33%> (-3.10%)` | :arrow_down: | | [...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Phi%2FPhi3%2FPhi3CausalLMAgent.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5QaGkvUGhpMy9QaGkzQ2F1c2FsTE1BZ2VudC5jcw==) | `52.00% <60.00%> (-4.72%)` | :arrow_down: | | [...soft.ML.GenAI.LLaMA/Llama3\_1ChatTemplateBuilder.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.LLaMA%2FLlama3_1ChatTemplateBuilder.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5MTGFNQS9MbGFtYTNfMUNoYXRUZW1wbGF0ZUJ1aWxkZXIuY3M=) | `68.83% <69.23%> (+0.20%)` | :arrow_up: | | [...crosoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.LLaMA%2FLlama3CausalLMChatClient.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5MTGFNQS9MbGFtYTNDYXVzYWxMTUNoYXRDbGllbnQuY3M=) | `0.00% <0.00%> (ø)` | | | [...rosoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Phi%2FPhi3%2FPhi3CausalLMChatClient.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5QaGkvUGhpMy9QaGkzQ2F1c2FsTE1DaGF0Q2xpZW50LmNz) | `0.00% <0.00%> (ø)` | | | [...osoft.ML.GenAI.Phi/Phi3/Phi3ChatTemplateBuilder.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Phi%2FPhi3%2FPhi3ChatTemplateBuilder.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5QaGkvUGhpMy9QaGkzQ2hhdFRlbXBsYXRlQnVpbGRlci5jcw==) | `43.83% <43.83%> (ø)` | | | [...rosoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298?src=pr&el=tree&filepath=src%2FMicrosoft.ML.GenAI.Core%2FCausalLMPipelineChatClient.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5NTC5HZW5BSS5Db3JlL0NhdXNhbExNUGlwZWxpbmVDaGF0Q2xpZW50LmNz) | `0.00% <0.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7298/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)