search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

[release/4.0] Fixing native lookup #7300

Closed github-actions[bot] closed 1 week ago

github-actions[bot] commented 1 week ago

Backport of #7282 to release/4.0

/cc @michaelgsharp

Customer Impact

Testing

Risk

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (abd799d) to head (e363106). Report is 2 commits behind head on release/4.0.

Files with missing lines Patch % Lines
...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs 0.00% 3 Missing and 1 partial :warning:
...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs 62.50% 1 Missing and 2 partials :warning:
...Common/Attributes/NativeDependencyFactAttribute.cs 0.00% 1 Missing and 1 partial :warning:
...mmon/Attributes/NativeDependencyTheoryAttribute.cs 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/4.0 #7300 +/- ## =============================================== - Coverage 68.84% 68.84% -0.01% =============================================== Files 1473 1473 Lines 274159 274173 +14 Branches 28420 28424 +4 =============================================== + Hits 188749 188752 +3 - Misses 78096 78100 +4 - Partials 7314 7321 +7 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.84% <31.25%> (-0.01%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.29% <ø> (-0.01%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.16% <31.25%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [...Common/Attributes/NativeDependencyFactAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FAttributes%2FNativeDependencyFactAttribute.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9BdHRyaWJ1dGVzL05hdGl2ZURlcGVuZGVuY3lGYWN0QXR0cmlidXRlLmNz) | `77.77% <0.00%> (-22.23%)` | :arrow_down: | | [...mmon/Attributes/NativeDependencyTheoryAttribute.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FAttributes%2FNativeDependencyTheoryAttribute.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9BdHRyaWJ1dGVzL05hdGl2ZURlcGVuZGVuY3lUaGVvcnlBdHRyaWJ1dGUuY3M=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: | | [...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FUtility%2FNativeLibrary.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9VdGlsaXR5L05hdGl2ZUxpYnJhcnkuY3M=) | `52.94% <62.50%> (+1.32%)` | :arrow_up: | | [...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300?src=pr&el=tree&filepath=test%2FMicrosoft.ML.TestFrameworkCommon%2FUtility%2FPathResolver.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdEZyYW1ld29ya0NvbW1vbi9VdGlsaXR5L1BhdGhSZXNvbHZlci5jcw==) | `64.28% <0.00%> (-3.22%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7300/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)