search

dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Update dependencies from maintenance-packages to latest versions #7301

Closed carlossanlop closed 1 week ago

carlossanlop commented 1 week ago

The latest prerelease versions can be found here: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries

Tomorrow we can update to the stable versions after they get published to nuget.

carlossanlop commented 1 week ago

I am seeing a new failure and it is coming from System.Data.SqlClient (sni.dll not found):

Microsoft.ML.Tests.DatabaseLoaderTests.IrisSdcaMaximumEntropy [FAIL]
      System.DllNotFoundException : Unable to load DLL 'sni.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
Finished test: Microsoft.ML.Tests.DatabaseLoaderTests.IrisLightGbmWithTimeout with memory usage 180,908,032.00 and max memory usage 372,355,072.00
      Stack Trace:
           at System.Data.SqlClient.SNINativeMethodWrapper.UnmanagedIsTokenRestricted(IntPtr token, Boolean& isRestricted)
           at System.Data.Win32NativeMethods.IsTokenRestrictedWrapper(IntPtr token)
           at System.Data.ProviderBase.DbConnectionPoolIdentity.GetCurrentNative()
           at System.Data.ProviderBase.DbConnectionPoolIdentity.GetCurrent()
           at System.Data.ProviderBase.DbConnectionPoolGroup.GetConnectionPool(DbConnectionFactory connectionFactory)
           at System.Data.ProviderBase.DbConnectionFactory.GetConnectionPool(DbConnection owningObject, DbConnectionPoolGroup connectionPoolGroup)
           at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
           at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
           at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
           at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
           at System.Data.SqlClient.SqlConnection.Open()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(64,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_Connection()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(76,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_Command()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(90,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.get_DataReader()
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(769,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.GetColumnIndex(ColInfo colInfo)
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(327,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.CreateInt32GetterDelegate(ColInfo colInfo)
        D:\a\_work\1\s\src\Microsoft.ML.Data\DataLoadSave\Database\DatabaseLoaderCursor.cs(205,0): at Microsoft.ML.Data.DatabaseLoader.Cursor.CreateGetterDelegate[TValue](Int32 col)
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.88%. Comparing base (e968d32) to head (1a48027). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7301 +/- ## ========================================== + Coverage 68.87% 68.88% +0.01% ========================================== Files 1470 1470 Lines 274005 274005 Branches 28403 28403 ========================================== + Hits 188725 188756 +31 + Misses 77962 77932 -30 + Partials 7318 7317 -1 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.88% <ø> (+0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.30% <ø> (+0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [test/Microsoft.ML.Tests/DatabaseLoaderTests.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301?src=pr&el=tree&filepath=test%2FMicrosoft.ML.Tests%2FDatabaseLoaderTests.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-dGVzdC9NaWNyb3NvZnQuTUwuVGVzdHMvRGF0YWJhc2VMb2FkZXJUZXN0cy5jcw==) | `94.41% <ø> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7301/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)
michaelgsharp commented 1 week ago

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

ericstj commented 1 week ago

We should remove that reference to SNI. Right fix is here: https://github.com/dotnet/maintenance-packages/pull/169