dotnet / machinelearning

ML.NET is an open source and cross-platform machine learning framework for .NET.
https://dot.net/ml
MIT License
9.05k stars 1.88k forks source link

Fix broken inheritance from DataFrameColumn class #7324

Open asmirnov82 opened 1 day ago

asmirnov82 commented 1 day ago

Fixes #7323

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (cfc1fb5) to head (798bde9). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 0.00% 1 Missing :warning:
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7324 +/- ## ======================================= Coverage 68.88% 68.88% ======================================= Files 1470 1470 Lines 274005 274005 Branches 28403 28403 ======================================= + Hits 188736 188739 +3 + Misses 77950 77949 -1 + Partials 7319 7317 -2 ``` | [Flag](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `68.88% <0.00%> (+<0.01%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `63.29% <0.00%> (+<0.01%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `89.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [src/Microsoft.Data.Analysis/DataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbi5jcw==) | `65.46% <ø> (ø)` | | | [...Analysis/DataFrameColumns/StringDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FStringDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvU3RyaW5nRGF0YUZyYW1lQ29sdW1uLmNz) | `68.15% <ø> (ø)` | | | [...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FPrimitiveDataFrameColumn.Sort.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL1ByaW1pdGl2ZURhdGFGcmFtZUNvbHVtbi5Tb3J0LmNz) | `87.80% <ø> (ø)` | | | [...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FArrowStringDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvQXJyb3dTdHJpbmdEYXRhRnJhbWVDb2x1bW4uY3M=) | `59.16% <0.00%> (ø)` | | | [...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324?src=pr&el=tree&filepath=src%2FMicrosoft.Data.Analysis%2FDataFrameColumns%2FVBufferDataFrameColumn.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#diff-c3JjL01pY3Jvc29mdC5EYXRhLkFuYWx5c2lzL0RhdGFGcmFtZUNvbHVtbnMvVkJ1ZmZlckRhdGFGcmFtZUNvbHVtbi5jcw==) | `44.57% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/dotnet/machinelearning/pull/7324/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet)

🚨 Try these New Features: