The FileVersions and PackageVersions for projects within the repository are less than the last package shipped.

carlossanlop commented 3 months ago

Affects at least HashCode and Xml.

ViktorHofer commented 3 months ago

From what I can see, the PackageVersion is correctly set-up everywhere but the AssemblyFileVersion assembly metadata is definitely lower than the last shipped versions for S.X.XPath.XmlDocument.

carlossanlop commented 4 weeks ago

Affects at least HashCode and Xml.

Microsoft.Bcl.HashCode looks correct:

Latest DLL from NuGet.org:

[assembly: AssemblyFileVersion("4.700.20.56604")]
[assembly: AssemblyInformationalVersion("3.1.11+59d2f36ec02c494eec50940c7993257a807f9531")]
[assembly: AssemblyVersion("1.0.0.0")]

Latest DLL from dotnet-libraries feed:

[assembly: AssemblyFileVersion("6.0.24.52904")]
[assembly: AssemblyInformationalVersion("6.0.0-preview.1.24529.4+c217b3e67dea4a77c604440fdf5ee9197565fbee")]
[assembly: AssemblyVersion("6.0.0.0")]

The latest Version in nuget matches the VersionPrevis and PackageValidationBaselineVersion:

  <PropertyGroup>
    <IsPackable>true</IsPackable>
    <VersionPrefix>1.1.1</VersionPrefix>
    <VersionPrefix Condition="'$(IsPackable)' == 'true'">6.0.0</VersionPrefix>
    <PackageValidationBaselineVersion>1.1.1</PackageValidationBaselineVersion>
  </PropertyGroup>

carlossanlop commented 4 weeks ago

but the AssemblyFileVersion assembly metadata is definitely lower than the last shipped versions for S.X.XPath.XmlDocument.

System.Xml.XPath.XmlDocument is wrong:

Laetst DLL from NuGet.org

[assembly: AssemblyFileVersion("4.6.24705.01")]
[assembly: AssemblyInformationalVersion("4.6.24705.01. Commit Hash: 4d1af962ca0fede10beb01d197367c2f90e92c97")]
[assembly: AssemblyVersion("4.0.2.0")]

Latest DLL from dotnet-libraries feed:

[assembly: AssemblyFileVersion("4.400.24.52904")]
[assembly: AssemblyInformationalVersion("4.4.0-preview.1.24529.4+c217b3e67dea4a77c604440fdf5ee9197565fbee")]
[assembly: AssemblyVersion("4.4.0.0")]

So what happened to the 4.3.0 that we have in nuget?

I'm confused. it's the only assembly where the VersionPrefix and PackageValidationBaselineVersion did not match this number:

  <PropertyGroup>
    <IsPackable>true</IsPackable>
    <VersionPrefix>4.3.0</VersionPrefix>
    <VersionPrefix Condition="'$(IsPackable)' == 'true'">4.4.0</VersionPrefix>
    <PackageValidationBaselineVersion>4.3.0</PackageValidationBaselineVersion>
  </PropertyGroup>

In the 1.1 corefx tag, the file under /pkg/Micorosoft.Private.PackageBaseline/packageIndex.json has these numbers too: https://github.com/dotnet/corefx/blob/26264e3fd68356ff1a98375161b67b4426d02774/pkg/Microsoft.Private.PackageBaseline/packageIndex.json#L2629-L2641

    "System.Xml.XPath.XmlDocument": {
      "StableVersions": [
        "4.0.1",
        "4.0.0",
        "4.3.0"
      ],
      "BaselineVersion": "4.3.0",
      "AssemblyVersionInPackageVersion": {
        "4.0.1.0": "4.0.1",
        "4.0.2.0": "4.3.0",
        "4.0.0.0": "4.0.0"
      }
    },

So where did that 4.6.0 come from?

dotnet / maintenance-packages

The FileVersions and PackageVersions for projects within the repository are less than the last package shipped. #100