search

dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.
MIT License
16 stars 10 forks source link

Move IsPackable property down to Directory.Build.props for System.Runtime.CompilerServices.Unsafe #130

Closed carlossanlop closed 2 weeks ago

carlossanlop commented 2 weeks ago

The last official build that pushed the packages to the feed, pushed version 6.0.0-preview of S.R.C.U., which is wrong: Should've been 6.1.0-preview.

We were seeing the correct package version in local builds and in the CI because in both cases, we're force-passing the /p:IsPackable=true property in the command line. But we don't do that in the official build.

I opened the fixed nupkg, then opened the two DLLs (netstandard2.0 and net462) with ILSpy, and confirmed that the correct version 6.1.0 is also stored in the metadata.