Closed ericstj closed 1 month ago
As mentioned in https://github.com/dotnet/runtime/pull/108806#discussion_r1799772471 assemblies built from this repo are missing CLSCompliantAttribute
CLSCompliantAttribute
Also some other metadata attributes, NeutralResourcesLanguage, DefaultDllImportSearchPathsAttribute. They are also missing some other centrally applied attributes. dotnet/runtime handles these here: https://github.com/dotnet/runtime/blob/6d23f64952d0f242c4dcc7cbb230a619be930309/eng/versioning.targets#L11-L57
A good test would be to compare the attributes present on the netstandard2.0 assembly of the old package and new to see if anything important is missing. You can disassemble them with your tool of choice (ildasm, ILSpy, GenAPI, etc).
netstandard2.0
Here's a sample:
Fixed by https://github.com/dotnet/maintenance-packages/pull/135
ViktorHofer
commented
1 month ago
As mentioned in https://github.com/dotnet/runtime/pull/108806#discussion_r1799772471 assemblies built from this repo are missing
CLSCompliantAttributeAlso some other metadata attributes, NeutralResourcesLanguage, DefaultDllImportSearchPathsAttribute. They are also missing some other centrally applied attributes. dotnet/runtime handles these here: https://github.com/dotnet/runtime/blob/6d23f64952d0f242c4dcc7cbb230a619be930309/eng/versioning.targets#L11-L57
A good test would be to compare the attributes present on the
netstandard2.0assembly of the old package and new to see if anything important is missing. You can disassemble them with your tool of choice (ildasm, ILSpy, GenAPI, etc).Here's a sample: