Closed carlossanlop closed 2 weeks ago
LGTM: In addition to answering Viktor's question - make sure you add to your documentation PR the two options for documentation.
LGTM: In addition to answering Viktor's question - make sure you add to your documentation PR the two options for documentation.
Thanks! Question answered, and I added a TODO reminder in the documentation PR.
The test commit has been reverted, it was just to show how I tested it.
With this change, we can add new assemblies that can opt-in to using triple slash comments as source of truth, instead of a checked-in xml file, by simply setting
GenerateDocumentationFile
totrue
in the csproj.I tested building and packaging using the temporary commit (will revert it before merging).
I confirmed that the xml for System.Buffers is generated and it is used instead of the commited file. I could find the generated xml in these 3 locations:
<Config>
/<TargetFramework>
/System.Buffers.xml<Config>
/<TargetFramework>
/System.Buffers.xml - This was allowed by bringing AnnotateTargetPathWithTargetPlatformMonikerWithDocFileItem.<TargetFramework>
/System.Buffers.xml