dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.
MIT License
22 stars 10 forks source link

Revert setting DotNetFinalVersionKind to release #156

Closed carlossanlop closed 3 weeks ago

carlossanlop commented 3 weeks ago

We were able to confirm that the stable builds work as expected. The commit in main that set the DotNetFinalVersionKind property to release caused the expected things to happen:

But creating isolated feeds and being in perpetual "stable" state is unnecessarily risky. We need to be able to first test packages before publishing the stable version.

So in conversation with @ViktorHofer and as suggested by @ericstj here, we will opt for keeping the branch in prerelease mode (by simply deleting the property) and when the time comes to publish a new version, we will manually trigger a job passing DotNetFinalVersionKind as an environment variable with the release value.

Note: I am testing the env var usage internally and separate to this PR.