dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.
MIT License
22 stars 10 forks source link

Remove AssemblyVersion pinned constraint for .NET Standard #160

Closed carlossanlop closed 1 week ago

carlossanlop commented 2 weeks ago

Fixes https://github.com/dotnet/maintenance-packages/issues/159

We need to make sure that the AssemblyVersion for the netstandard2.0 DLLs of the new packages is greater than the AssemblyVersion for the netstandard2.0 DLLs of the last released packages in nuget.org, similar to what we've been doing for .NET Framework AssemblyVersions.

For some of these cases we need to be mindful of keeping the new netstandard2.0 AssemblyVersion under the AssemblyVersion of the last released netcoreappX.X version.

I collected all the numbers before and after:


System.Buffers

C:\Program Files\dotnet (netcoreapp2.1):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Memory

C:\Program Files\dotnet (netcoreapp2.1):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Numerics.Vectors

C:\Program Files\dotnet (netcoreapp2.1):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Runtime.CompilerServices.Unsafe

C:\Program Files\dotnet (net6.0):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Threading.Tasks.Extensions

C:\Program Files\dotnet (netcoreapp2.1):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Reflection.DispatchProxy

C:\Program Files\dotnet (netcoreapp3.1):

nuget.org (netstandard2.0):

main (netstandard2.0):

This PR (netstandard2.0):


System.Data.SqlClient

This assembly does not need the change.

carlossanlop commented 2 weeks ago

Looking at the errors.

ViktorHofer commented 1 week ago

In general, if a previously frozen AssemblyVersion property isn't frozen anymore, please move it into the PropertyGroup that contains all the moving versions. And put the properties with the same name together.