search

dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.
MIT License
22 stars 10 forks source link

Version packages and assembly versions to the next patch digit #166

Closed ViktorHofer closed 1 week ago

ViktorHofer commented 1 week ago

This needs to wait until the current packages got released to nuget.org.

carlossanlop commented 1 week ago

ApiCompat failures:

Unnecessary suppressions found. The APICompat suppression file can be updated by rebuilding with
 '/p:ApiCompatGenerateSuppressionFile=true' [/__w/1/s/src/System.Numerics.Vectors/src/System.Numerics.Vectors.csproj]
[Baseline] CP0003
 (Target: 'System.Numerics.Vectors, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a',
 Left: 'lib/netstandard2.0/System.Numerics.Vectors.dll', Right: 'lib/netstandard2.0/System.Numerics.Vectors.dll')
Unnecessary suppressions found. The APICompat suppression file can be updated by rebuilding with
 '/p:ApiCompatGenerateSuppressionFile=true' [/__w/1/s/src/System.Buffers/src/System.Buffers.csproj]
[Baseline] CP0003
 (Target: 'System.Buffers, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51',
 Left: 'lib/netstandard2.0/System.Buffers.dll', Right: 'lib/netstandard2.0/System.Buffers.dll')
ViktorHofer commented 1 week ago

LGTM but I wanted to ask if we should increase the AssemblyVersion's minor value, not the major value

This PR updates the build/patch (the third digit) version of the hardcoded package and assembly versions. Are you asking whether we should update the revision of the hardcoded assembly versions (the fourth digit)?

carlossanlop commented 1 week ago

This PR updates the build/patch (the third digit) version of the hardcoded package and assembly versions. Are you asking whether we should update the revision for the hardcoded assembly versions (the fourth digit)?

Yes. Would that cause problems? Example: Instead of going from 1.2.3.4 to 1.2.4.0, go to 1.2.3.5.

Edit: Depending on the answer, I'd have to modify the readme PR: https://github.com/dotnet/maintenance-packages/pull/39

carlossanlop commented 1 week ago

New ApiCompat failures after the last commit:

Unnecessary suppressions found. The APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'
[Baseline] CP0003 
(Target: 'System.Numerics.Vectors, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a', 
Left: 'lib/netstandard2.0/System.Numerics.Vectors.dll', 
Right: 'lib/netstandard2.0/System.Numerics.Vectors.dll')
ViktorHofer commented 1 week ago

Honestly, I don't think that's necessary. The format between the AssemblyVersion and PackageVersion is different and so I would rather try to keep them in sync by not touching the Revision (fourth digit) that is only available for the AssemlbyVersion. I don't think that we could easily run out of space given that we can have versions like x.x.55.x. The third part doesn't need to be < 10.

carlossanlop commented 1 week ago

Alright, sounds good. Do the honors and hit that merge button.