search

dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.
MIT License
22 stars 10 forks source link

Migrate System.ValueTuple #185

Closed carlossanlop closed 1 day ago

carlossanlop commented 2 days ago

Merge commit.

No additional code changes, only migration. Will fix the infra after merge-commiting this.

Contributes to https://github.com/dotnet/maintenance-packages/issues/183

ViktorHofer commented 1 day ago

I'm not sure what you want me to review. Do you just need an approval? If I understand correctly, most of the files are going to be deleted with a subsequent PR as those aren't necessary anymore (i.e. pkgproj, sln file, Configurations.props, etc).

Just curious, why don't you include the repo infrastructure integration changes as part of this PR?

carlossanlop commented 1 day ago

We did that with SqlClient. First we only merged the commits, then the next PR was much easier to review, as it would not include hundreds of new commits and files. Also, if I need to merge main into my working branch, it's not going to make a mess of my commits when I need to squash my new changes at the end.

Can you please approve? No need to review the content.