Build migrated System.ValueTuple

dotnet / maintenance-packages

Repository that hosts packages from the .NET platform whose original home/branch is not building any longer.

MIT License

22 stars 10 forks source link

Build migrated System.ValueTuple #186

Open carlossanlop opened 5 days ago

carlossanlop commented 5 days ago

Migrated from 2.1.

The last released version of this package (4.5.0) targeted these frameworks:

net461 - Actual implementation.
net47 - Type forwards.
netcoreapp2.0 - Placeholder.
netstandard2.0 - Placeholder.

The new version of the package will have to target:

net462 - With an actual implementation.
net47 - Type forward again.
netcoreapp2.0 - Placeholder.
netstandard2.0 - Placeholder.

ViktorHofer commented 1 day ago

Any idea why for net47 we have a type forward assembly instead of just a placeholder file like with the other TFMs?

carlossanlop commented 1 day ago

Any idea why for net47 we have a type forward assembly instead of just a placeholder file like with the other TFMs?

System.ValueTuple is part of the shared framework in net461 and net47, but not in all others.

ViktorHofer commented 1 day ago

System.ValueTuple is part of the shared framework in net461 and net47, but not in all others.

System.ValueTuple isn't part of .NET Framework 4.6.1. It got moved inbox with 4.7:

https://apisof.net/catalog/f25ce1f51db08b3f9b38d40c4b569e02

ViktorHofer commented 1 day ago

Spoke with @ericstj offline. System.ValueTuple got moved inbox with 4.7 but into mscorlib.dll, therefore type forwards are needed. Later with 4.7.1 a System.ValueTuple facade assembly got added inbox.

For the new package, net462 has the real implementation, net47 should be a typeforwards assembly and (optionally, but IMO makes sense) net471 should be a placeholder file.