Closed cheenamalhotra closed 1 month ago
I didn't address all the feedback here, but here's a sample that shows getting the src project building. https://github.com/ericstj/maintenance-packages/tree/ericstj/sqlClient-hacking
This could be helpful if you'd like to push this to a place where you can polish / iterate on feedback and get the tests running.
@cheenamalhotra can you please update this PR? This port needs to be complete by the time we ship maintenance-packages so that SqlClient remains serviceable. We also need a package README added here.
@cheenamalhotra I hope you don't mind - I force-pushed to this branch to resolve the merge conflicts with the main branch. We had several changes that would benefit this PR, but they needed to be merged before the last commit you added (which moved the code from the migrated
folder to the src
folder). I took care of it, and now we are getting meaningful error messages during the build.
Replaced with #115
Got source code migrated using the Migration script, but still need to do some changes to make things work in the project architecture. Opening PR to get some help from @carlossanlop to make this move faster..
Edit by @carlossanlop:
When targeting
net462
, running the codetypeof(System.Data.SqlClient.SqlError).Assembly.CodeBase
returnsfile:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/System.Data/v4.0_4.0.0.0__b77a5c561934e089/System.Data.dll
, meaning we type forward to the shared framework, so we don't need to include that tfm in this new package version.When targeting
net6.0-windows
, the codetypeof(System.Data.SqlClient.SqlError).Assembly.CodeBase
returnsfile:///C:/Users/calope/source/repos/tools/AssemblyChecker/Downloader/bin/Debug/net6.0-windows/runtimes/win/lib/netstandard1.3/System.Data.SqlClient.dll
, the package DLL, so we need to include these suffixed tfms.