search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.06k stars 1.73k forks source link

XAML Hot Reload fails with TypeConverter for RowDefinitionCollection error #10679

Closed davidortinau closed 1 year ago

davidortinau commented 2 years ago

Description

I'm unable to use XAML Hot Reload on this page. I'm running RC2 and VS main.

image

Steps to Reproduce

OrdersPage.xaml

Link to public reproduction project repository

https://github.com/dotnet/maui-samples/tree/main/6.0/Apps/PointOfSale/src/PointOfSale

Version with bug

Unknown/Other (please specify)

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, I was not able test on other platforms

Affected platform versions

latest

Did you find any workaround?

No response

Relevant log output

No response

SophisticatedConsulting commented 2 years ago

I also have this problem and it is a big pain to debug as many pages have grids with column/row definitions. 17.4 Preview 2.1

drasticactions commented 2 years ago

@davidortinau Does RowDefinitionCollection support converting from a string? Does it work if you try that from C# Code Behind setting that value?

The error is correct if it doesn't support converting from a string. If you can't change those values from code behind, it also won't work.

This error is thrown in the Markup Extension Parser. It's not hitting the XAML Hot Reload agents.

CC @mgoertz-msft @chabiss as you may know about the underlying code.

etvorun commented 1 year ago

https://github.com/dotnet/maui/pull/9447 is needed for MAUI v6. Currently it is available in 7.0.0-rc.1 only

Redth commented 1 year ago

Fixed by https://github.com/dotnet/maui/issues/10679