search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22k stars 1.72k forks source link

Setter TargetName="check" Property="Opacity" breaks hot reload #10915

Open mcpbcs opened 1 year ago

mcpbcs commented 1 year ago

Description

When you uses a custom radio button and you are setting the opacity property the hot reload just break.

Steps to Reproduce

  1. create a maui app.
  2. paste this code

change text and the hotload is not working. NewPage1.zip

comment the <!--<Setter TargetName="check" Property="Opacity" Value="1" />-->

Link to public reproduction project repository

https://github.com/dotnet/maui-samples/blob/main/6.0/UserInterface/Views/RadioButtonDemos/RadioButtonDemos/Views/RadioButtonControlTemplatePage.xaml

Version with bug

Unknown/Other (please specify)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 8.1 Api 27

Did you find any workaround?

comment the

Relevant log output

No response

ghost commented 1 year ago

Hi @mcpbcs. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

PureWeen commented 1 year ago

Can you expand on "breaks hot reload"?

Does it just not work for this one property? Or hot reload completely stops working everywhere?

mcpbcs commented 1 year ago

hot reload completely stops working only when the line is not commented..

ghost commented 1 year ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

jonathanpeppers commented 1 year ago

This is duplicate of: https://github.com/dotnet/maui/issues/11082

When you remove a <Setter TargetName="check" Property="Opacity" Value="1" />, then it doesn't know the original value of what Opacity should be.

samhouts commented 1 year ago

Duplicate of #11082

BretJohnson commented 1 month ago

Reopening, as this still fails in .NET8, even with the setter specificity changes included. The error is different though, showing what's below. This is an issue with the Hot Reload code, which we're tracking here (for Microsoft internals): https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2251809

image