dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.27k stars 1.76k forks source link

[Not Planned] Work required to better enable adding platforms to MAUI #12947

Open PureWeen opened 1 year ago

PureWeen commented 1 year ago

Description

These items are based on a quick spike adding WPF here This is in no way an indication of future plans. This is just PureWeen testing something out and seeing areas where we could easily expose some more public APIs.

First impression

You can get pretty far with the current implementation.

I was able to get some features here working https://github.com/PureWeen/maui/tree/wpf_separate_project/src/Controls/samples/Controls.Sample.WPF.

ghost commented 1 year ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

rmarinho commented 1 year ago

Did we get an idea what we need to change on the targets to make condition based on WinUI and not windows?!

PureWeen commented 1 year ago

Did we get an idea what we need to change on the targets to make condition based on WinUI and not windows?!

Yea I basically have those changes here https://github.com/dotnet/maui/compare/main...PureWeen:maui:wpf_separate_project

For my spike I'm keying off of UseWpf but it'd probably be better to key off of something inside WinUI instead.

Replace this conditional here https://github.com/dotnet/maui/compare/main...PureWeen:maui:wpf_separate_project#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR23

With something a bit more elegant