dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.28k stars 1.76k forks source link

[Windows] Review currently failing Windows tests #15530

Open PureWeen opened 1 year ago

PureWeen commented 1 year ago

Description

As part of https://github.com/dotnet/maui/pull/15527 I've skipped the tests listed below. All of these tests were failing on the original PR. We don't necessarily need to fix these issues for .NET8 but we should establish if we should fix these for .NET8 or just fix the tests themselves.

In addition after merging #15629 we're now running the DeviceTests for Windows, these have been disabled because they were failing and we should look into them.

Core At the time of writing the whole Core project test runs have been disabled because it would crash while running, so that is something we need to fix, other than that, these tests are failing:

BlazorWebView https://github.com/dotnet/maui/issues/16187

Essentials

Controls Just like Core, the Controls projects also crashes somewhere along the test run and never completes. We need to investigate why and enable it for running on CI again

Unpackaged Then we need to run this full suite also for unpackaged apps. I think we can make this a variation by leveraging the device parameter that is in place for iOS and Android and add that to the matrix for Windows

Random

Vroomer commented 1 year ago

https://twitter.com/dotnetmeme/status/1618259119974252545 It's ok, we enjoy broken CollectionView on Windows. It's not like we expected you to fix it in a year after GA, so just remove the tests and everything will be fine. It was obvious that Windows is something Microsoft won't bother to support.

jonathanpeppers commented 1 year ago

@PureWeen are these running on CI now? It probably not very impactful to fix these tests unless we are running them?

PureWeen commented 1 year ago

@jonathanpeppers we're getting CI spun up here soon so I'm just trying to gauge what to do about these failures for tracking purposes

Or some combination of those

jonathanpeppers commented 1 year ago

Let me know when Windows device tests are running on CI, as I probably won't fix the ones above until then.

They are probably not real bugs, but something with the tests themselves.

PureWeen commented 1 year ago

@jonathanpeppers sounds good! We have them marked as skip for now.

jfversluis commented 1 year ago

@jonathanpeppers not sure you're still interested and just caught this now... But I think all Windows tests are now running on CI. So if you have still something to do here, do it now! ✨

ghost commented 11 months ago

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.